search

speced / bikeshed

:bike: A preprocessor for anyone writing specifications that converts source files into actual specs.
https://speced.github.io/bikeshed
Creative Commons Zero v1.0 Universal
1.12k stars 201 forks source link

bikeshed emitting `path` attributes on html elements #2067

Closed mozfreddyb closed 3 years ago

mozfreddyb commented 3 years ago

Hi,

I am currently facing an issue with submitting HTML through the Nu Html Checker, which complains about path attributes on generated HTML.

To be fair, I am not sure if it's reasonable for bikeshed to switch to conformant HTML output (e.g., data-path?) or whether this is acceptable behavior for bikeshed.

My bikeshed snippet looks like this:

<pre class=include-code>
path: resources/baseline-element-allow-list.json
highlight: js
</pre>

and the generated HTML looks like this

<pre class="include-code highlight" path="resources/baseline-element-allow-list.json">....

The full files are available in a spec PR, which contains a GitHub actions tab with a lot of logs and more context, for your convenience :)

Thanks!

tabatkins commented 3 years ago

Ah, that's a bug, it should be removed in the output. Thanks for the report!

mozfreddyb commented 3 years ago

I can try and write a pull request, if you can point me to the approximate source lines (and if you think this is easy enough to do :))

tabatkins commented 3 years ago

I'm fixing it right now, no worries.

tabatkins commented 3 years ago

Whoops, stripped them too early, highlighting isn't triggering now.