Remove raw HTML string interpolation

[saschanaz]

One consensus in #2548 is that we should remove raw string interpolations. Now we can easily remove them since the PR found all the raw things 🎉

• Where are those interpolations?: Find-on-page by raw( and all of them are raw string interpolations. There are 21 matches as of now.
• How to remove them?: Convert them to inline Node or Element elements, e.g. html`<var>${str}</var>`

[saschanaz]

@marcoscaceres Candidate for good first issue? 👀

[marcoscaceres]

I think so! We just need to make them super easy to find, and really clear how to fix them.

[saschanaz]

Do we want to keep conf.*HTML e.g. conf.wgHTML or not?

[marcoscaceres]

I don't think so... those are all part of the "override" tag'ed tasks.

[saschanaz]

I don't think so... those are all part of the "override" tag'ed tasks.

You mean you want to remove the overriding things? GitHub search shows only one use of wgHTML which is marked as old 👀

[marcoscaceres]

Maybe we can just entirely remove that.

What I mean is, for a lot of things that insert html from config, authors should be actually writing those things directly in the document. There are whole bunch of these: https://github.com/w3c/respec/issues?q=is%3Aissue+is%3Aopen+label%3AOverride

[saschanaz]

Right, just like how additional SOTD contents are processed.

[deepesh-ludhyani]

I would be glad to try to solve this issue.

[saschanaz]

Hello @deepesh-ludhyani, I'm assigning you for this issue then! Feel free to ask questions whenever needed. 👍

[SuyashSalampuria]

@saschanaz if no one is working on this, shall I try to solve this issue

[saschanaz]

@deepesh-ludhyani Are you working on this?

[SuyashSalampuria]

@saschanaz I am starting to work on this issue Can you confirm if I have understood the issue correctly Please confirm if have to convert to <li> <a href="${href}"> ${testFileName} </a> ${emojiList} </li>

[saschanaz]

@SuyashSalampuria No, that one is fine. What do we want is that we replace normal JavaScript strings into hyperHTML templated string so that we get all of its feature including escaping.

So for example:

const element = `<p>${content}</p>`;

Should be:

const element = html`<p>${content}</p>`;

...although it'll be more complex than this.

[marcoscaceres]

@saschanaz, as this is security critical, I'd be more comfortable if you were working on it.

[SuyashSalampuria]

I have tried my best to understand the problem and solve it. Although, this was my first contribution to open source. Please tell me if I have understood the problem correctly and solved it as required

[ridhishjain-zepto]

@saschanaz, can I take this issue? or anyone else is working on it?

[saschanaz]

Several are already removed by others, not sure whether there is a remaining. If you can find one, please do.

[ridhishjain-zepto]

I did not find any in src/w3c, src/ui and, src/geonovum any other directories to look for? otherwise, the issue is resolved I guess