speced / respec

A tool for creating technical documents and web standards
https://respec.org/
Other
709 stars 376 forks source link

fix!(w3c/style): override color-scheme with meta tag #4700

Closed marcoscaceres closed 2 months ago

marcoscaceres commented 2 months ago

Removes the opt in respecConfig.darkMode option, allowing HTML's meta tag to be used instead.

sidvishnoi commented 2 months ago

Let's still keep this behind darkMode flag for a while? It was added to prevent specs that use custom styles to opt-in to prevent breaks.

marcoscaceres commented 2 months ago

I still don’t feel that a configuration flag is the right approach. It should then be we inject the meta to default to “light”, allowing spec authors to then opt into light/dark.

Then the transitional path is that we announce this, and give everyone a year to check their specs before switching to light/dark.

marcoscaceres commented 2 months ago

Should be good to go now, @sidvishnoi.