spechub / Hets

The Heterogeneous Tool Set
http://hets.eu
GNU General Public License v2.0
57 stars 19 forks source link

hets -update does not catch curl errors #1009

Closed sternk closed 10 years ago

sternk commented 10 years ago

Reported by till and assigned to sternk Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009


When doing a hets -update without internet connection, the Hets binary will be deleted, because the curl error is not caught

sternk commented 10 years ago

Comment by maeder Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:1


Corneliu-Claudiu implemented this initially. The source file is now spechub/Hets:trunk/utils/debian/auto-package/debian-common/hets_script. Maybe Jonathan can have a look or who is familiar with python?

sternk commented 10 years ago

Comment by maeder Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:2


does "hets -revert" restore the old binary in this case?

sternk commented 10 years ago

Comment by sternk Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:3


hets -update should handle this case gracefully now and should be generally more robust i'm not really sure what you mean by "does "hets -revert" restore the old binary in this case?" currently hets behaves as follows: hets -update && hets -revert basically doesn't leave anything changed whereas hets -update && hets -update && hets -revert does not restore the hets version from the package but rather the latest version. I suppose this behaviour is not desirable and should be changed? I also noticed that hets -update doesn't deal with documentation and support libraries (maude, hol-light etc.). Is this something we should / want to fix?

sternk commented 10 years ago

Comment by maeder Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:4


I just wanted to know if "hets -revert" restores the old binary (as a workaround) if the current possibly failing "hets -update" deleted it. We do not need to support reverting several updates. If one wants to revert to the package version, (s)he needs to remove and (re-) install the hets-core package. I thought, "hets -update" would also checkout a current Hets-lib. I see no need to revert this. "hets -update" should not really be necessary if we make package updates to the hets-ppa.

sternk commented 10 years ago

Comment by sternk Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:5


yes, the binary is now restored if the update fails and yes, an up to date version of Hets-lib is checked out. This updated is rolled back on revert, but I can remove this behaviour if you consider it to be harmful or unwanted. But my question wasn't about Hets-lib but rather about the files provided by hets-hollight-tools, hets-doc etc.

sternk commented 10 years ago

Comment by maeder Migrated from http://trac.informatik.uni-bremen.de:8080/hets/ticket/1009#comment:6


I think, it is ok as it is now. For major changes a new release should be created.