specialtactics / laravel-api-boilerplate

Laravel API Boilerplate | Quickly build quality API products!
MIT License
490 stars 94 forks source link

[BUG] #43

Closed Eolykab closed 4 years ago

Eolykab commented 4 years ago

Version Information PHP Version: Package Version (l5-api):

Describe the bug I am getting an error when trying to setup docker. configure: error: Package requirements (oniguruma) were not met:

No package 'oniguruma' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix.

Alternatively, you may set the environment variables ONIG_CFLAGS and ONIG_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

To Reproduce When I run docker-compose up Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

specialtactics commented 4 years ago

Hey @Eolykab

Would I be correct to say you are trying to compile PHP 7.4 image ?

Eolykab commented 4 years ago

Yes correct

specialtactics commented 4 years ago

Hey @Eolykab , I will update the boilerplate to make PHP 7.4 default (for some reason I thought this was already the case)

Meanwhile, to fix this I think all you need to do is add this to the list of packages being installed at the top of the Dockerfile of the "php-fpm" and "workspace "containers (inside env/docker)

libonig-dev \

Eolykab commented 4 years ago

Works like a charm. Thanks

specialtactics commented 4 years ago

tagged as v2.0.3