search

specify / specify6

Source Code for Specify 6, Biological Collections Management Platform
https://specifysoftware.org
GNU General Public License v2.0
14 stars 6 forks source link

Cannot create Exchange Out record in restored databases #1170

Closed chanulee1 closed 1 year ago

chanulee1 commented 1 year ago

Loads forever when trying to create an Exchange Out record from a record set or by entering catalog numbers/identifiers in restored databases. Seems to work fine in newly created databases.

Restored databases used: freshfish, herb_rbge, cornell_birds Error messages (when creating from catalog numbers/identifiers):

image image

Seem to get these errors or something similar while loading.

benanhalt commented 1 year ago

@chanulee1 I think this might be fixed by the next build on the schema210 branch. Can you give it a try when you have a chance? Thanks

chanulee1 commented 1 year ago

@benanhalt Sorry for the delay. Works in cornell_birds. Dialog for preparation selection now appears. Still loads forever after this step for freshfish and herb_rbge.

herbrbge: image image

freshfish: image image

benanhalt commented 1 year ago

Looking at the freshfish database, the null pointer exception is arising from there being no element on the form for the division. In the common forms it is included as <cell type="field" id="divcbx" name="divisionCBX" uitype="combobox" ignore="true"/> and the NPE doesn't occur.

I have committed a change that will avoid the NPE in this circumstance, and in my testing it does allow the exchange out form in the freshfish database. However, that form is also missing the ExchangeOutNumber field so it is still not possible to save any record from it.

chanulee1 commented 1 year ago

I see. Seems to work!