specify / specify6

Source Code for Specify 6, Biological Collections Management Platform
https://specifysoftware.org
GNU General Public License v2.0
14 stars 6 forks source link

Collection Object Citation not available in carry forward #1179

Open grantfitzsimmons opened 1 year ago

grantfitzsimmons commented 1 year ago

Reported By: @Schuchert on the Community Forum

Context to this screenshot, I can confirm both collectionObjectCitations in the Collection Object table and the table itself are not hidden.

image

Here is the documentation that specifically says that Collectors, Determinations, and Citations can be carried over, leading me to be even more confused about why this is not functioning.

I spent some time going through the Specify 6 source code and all issues referencing carry forward but I can’t see a clear way to see which fields are supported. I forwarded the details to @melton-jason but there is some investigation to do. If this is an instance of misconfiguration or the fix is simple, please let me know!

specifysoftware commented 1 year ago

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/carry-forward-collection-object-citation-not-available/924/2

melton-jason commented 1 year ago

For future reference: This issue was occurring because CollectionObjectCitation has no implementation of a clone method, which Specify6 checks for and expects when checking if fields on a form can be carry-forwarded.

Check occurs here:

https://github.com/specify/specify6/blob/cb973abdf9fe030a0efc462d5aae0f7e45c14613/src/edu/ku/brc/af/ui/forms/FormViewObj.java#L1079-L1089

There are a number of other Citation tables which also do not implement a clone() method and thus can not be used for carry forward:

tlammer commented 1 year ago

taxa created using carry forward cannot be deleted in 6.8.03. That was not true in 6.8.02

tlammer commented 1 year ago

when taxon citation is not carried forward, the record created using carry forward can be deleted