search

specify / specify6

Source Code for Specify 6, Biological Collections Management Platform
https://specifysoftware.org
GNU General Public License v2.0
14 stars 6 forks source link

Don't zip .dmg files in actions #642

Open maxpatiiuk opened 4 years ago

maxpatiiuk commented 4 years ago

This is what a registered user sees on the Actions page

Screen Shot 2020-03-04 at 2 57 49 PM

When pressing on the Specify_macos_with_ticket or Specify_macos, the download of a .zip file begins. When the archive is downloaded (which takes some time), the user will find a .dmg the file inside, which is kind of an archive in itself, making it pointless to compress it again

Screen Shot 2020-03-04 at 2 57 30 PM

(almost no difference in file size)

Is it possible to upload the .dmg files to actions without zipping them?

Seems to be implemented fine for the releases

benanhalt commented 4 years ago

This is a github issue https://github.com/actions/upload-artifact/issues/3

maxpatiiuk commented 4 years ago

The v2 preview is out and ready for feedback! 😀

For more information see: #62

With the v2-preview you can now upload artifacts by specifying

  • An individual file
  • A directory
  • A wildcard pattern

Note: We only currently support downloading an artifact from the GitHub UI by zipping all the files together (this is independent of how the artifact gets uploaded). If you upload an individual file, in the UI the artifact will still present itself as a Zip because that is currently only what we support. We have plans in our roadmap to offer a more enhanced artifact UI experience that will allow you to browse and download individual files from an artifact. No ETA on when that might arrive, but it is something that we really really want to enhance.

Some more information about zipping and compression: https://github.com/actions/toolkit/blob/master/packages/artifact/docs/additional-information.md#is-my-artifact-compressed

https://github.com/actions/upload-artifact/issues/3#issuecomment-598820814