specify / specify7

Specify 7
https://www.specifysoftware.org/products/specify-7/
GNU General Public License v2.0
66 stars 36 forks source link

[a11y] Mapper reccomending NOT MAPPED in WB #1302

Closed grantfitzsimmons closed 2 years ago

grantfitzsimmons commented 2 years ago

Describe the bug NOT MAPPED is recommended & can precede valid mappings

To Reproduce Steps to reproduce the behavior:

  1. Go to the WB mapper
  2. See error when recommending children of Agents, in this case the collectors table
  3. You can use the Full Data Import sample from the newmexico db to test this

Expected behavior Not mapped should not be a valid option before a child

Screenshots image

Desktop (please complete the following information):

grantfitzsimmons commented 2 years ago

image See duplicate Collector table

grantfitzsimmons commented 2 years ago

Data Set uploaded. This Upload Plan cannot be changed

This is not correct AFAIK

maxpatiiuk commented 2 years ago

Fixed both issues. The auto mapper issue has been fixed in cases where I found, but there may be other cases where it would happen -> need more testing. @grantfitzsimmons I can't open WB in the newmexico database because of a server error. Can you test this data set again to see if the issues are fixed?

grantfitzsimmons commented 2 years ago

Presumably this is not fixed since @realVinayak was able to recreate

maxpatiiuk commented 2 years ago

There were several bugs connected with that system.

1395 was a different bug affecting the same system.

Both should be fixed now

grantfitzsimmons commented 2 years ago

Cautiously I believe these issues have been resolved- but I am able to get NOT MAPPED between one table and a chosen mapping (Any, Between, etc)

maxpatiiuk commented 2 years ago

Found yet another case where this happened. Should be fixed. if you encounter any more cases, please send the URLs or the screenshots