specify / specify7

Specify 7
https://www.specifysoftware.org/products/specify-7/
GNU General Public License v2.0
65 stars 36 forks source link

Wrong Data in Security and Accounts List of User Accounts Assigned to this Collection #3306

Open carlosmbe opened 1 year ago

carlosmbe commented 1 year ago

Describe the bug The list of users with access to this collection is inaccurate and lists all the users in the institution

To Reproduce Steps to reproduce the behavior:

  1. Log in as petrifiedroadkill in NHMD Test Database.
  2. Go to NHDM Amber Collection -> Security and Accounts
  3. Click on NHMD Amber
  4. See error

Expected behavior Only users with access should be shown

Screen Recording

https://user-images.githubusercontent.com/53784701/230147906-fd22dd47-c0f6-47e3-bd92-207d4e1ef20a.mp4

Desktop:

Database Name: NHMD Test

Reported By Carlos @carlosmbe

maxpatiiuk commented 1 year ago

The list in the collection screen shows all users that:

On that screen next to each user name you can see the list of roles that user holds Thus, this is correct behavior. @carlosmbe @grantfitzsimmons should it be changed in some way to make it less confusing or is this fine?

grantfitzsimmons commented 1 year ago

It's not very useful to show them even if they have a role as they can't access the collection– do you agree @maxpatiiuk ?

maxpatiiuk commented 1 year ago

The role was manually given to them (with exception of the legacy roles) If the role was given, then I would expect the user to show up on the list. I.e, if I temporary removed collection access for a user, I would expect that to still show up on the list so that I can easily re-enable collection access. There is also a problem of collection access possibly coming from a role, rather than being a direct policy

grantfitzsimmons commented 1 year ago

These are all legacy roles

emenslin commented 2 months ago

Can recreate in edge (7.9.6)