Don't show "Upload Completed With No Errors" popup if error occured during upload

[mpitblado]

Describe the bug After uploading data through the workbench, an error was produced and displayed to the user. After closing this error, another popup appears indicating that the upload was successful and asking the user if they would like to create a new record set. However, the upload process has not in fact been completed successfully (as evidenced by either running a query and having nothing returned for the new records that would have been uploaded, the lack of the usual "uploaded" indicators within the workbench, such as "uploaded-readonly", or "roll back") and the fact that the records will show as new records when validated again.

To Reproduce Steps to reproduce the behaviour:

1. Upload a dataset through the workbench that will produce a technical error (as I haven't come across this when normal business rules are displayed)
2. When the error message comes up, click on Stop
3. Observe that an Upload Successful Popup Appears, click close
4. Observe that the upload has not actually been completed.

Expected behaviour The Upload Successful Popup would not appear for uploads that were not successful. There does not need to be an additional popup displayed for technical errors, as the Error Popup will already inform the user of this.

Screenshots Error Popup with Stop button

Upload successful popup that appears after clicking Stop button on error message.

Header in Workbench after clicking close on Upload Successful Popup

Desktop:

• OS: Windows 10
• Browser: Firefox version 114.0.1
• Specify 7 Version: 7.8.11

Database Name: Not applicable.

Reported By Beaty Biodiversity Museum

[maxpatiiuk]

The bug is because the "Upload Completed With No Errors" message appears if upload process is completed (regardless of successfully or not) and there are 0 error cells - so if upload failed for reasons other than invalid cells, a wrong dialog is displayed.

[emenslin]

Can recreate in edge (7.9.6)