Disposals do not impact number of available preparations

[lexiclevenger]

Describe the bug After performing a disposal for a preparation object, the Current Count of preparations decreases, but the number of available preparations stays the same and allows for the preparations from the disposal to be loaned or gifted. Loaning or gifting these preparations will decrease the Current Count again and result in the count being negative.

To Reproduce Steps to reproduce the behavior:

1. Create a new Disposal
2. Add all available preparations for a collection object, save.
3. Go to the collection object form and see that the Current Count is 0.
4. Create a loan.
5. See that the preparations added to the Disposal are available, add preparations, save.
6. Go to the collection object form and see that the Current Count is a negative number.

Expected behavior Disposals should decrease the number of available preparations for a collection object.

Screenshots

Specify 7 System Information - 2024-04-25T19_26_12.430Z.txt

Please, also fill out the following information manually:

• OS: Mac
• Browser: Chrome
• Specify 7 Version: edge, 7.9.3.1
• Database Name: KUPaleoBot_8_31_2023
• Collection name: Paleobotany
• User Name: sppaleobotadmin

[grantfitzsimmons]

What is different between this and https://github.com/specify/specify7/issues/4655

[lexiclevenger]

What is different between this and #4655

I believe the problem is the same, but this issue highlights that preparations which have already been used in a disposal can still be added to interactions such as Loan and Gift. The current count reflects the correct number of preparations, as you mentioned in #4655, but the preparations are still available in the Preparations dialog for interactions. The dialog shown in the screenshot is for a Loan; there should be no preparations available according to the CO record behind it. I tested this again in edge, and the bug is still present.

Some additional details:

• After saving preparations that were used for a Disposal to a Loan or Gift, they are no longer marked as available.
• Because preparations are still marked as available after a disposal, the same preparations can be added to a disposal multiple times, resulting in a negative number in the Current Count field.

[emenslin]

Can recreate in edge (7.9.6) but cannot recreate the count being negative. You can add the same preparation to a disposal multiple times but the current count will just stay at zero

[bronwyncombs]

Jordi @ MCNB has also reported this and would like to see disposal preparations affect the availability of preparations when creating other interactions by searching Cat No

This should also apply to exchange out preparations