specify / specify7

Specify 7
https://www.specifysoftware.org/products/specify-7/
GNU General Public License v2.0
66 stars 36 forks source link

Fields with isrequired="true" attribute in form definition are not required in bulk carry forward configuration #5206

Open lexiclevenger opened 3 months ago

lexiclevenger commented 3 months ago

Describe the bug Fields that are not required in the database schema but have the attribute isrequired="true" in the form definition (this is common with the "cataloger" field on the CO form) are not marked as required in the bulk carry forward configuration dialog. If a record is bulk carried forward without these fields enabled, the resulting records cannot be modified and saved until the user inputs a value for it.

To Reproduce

  1. Make sure the "cataloger" field in the Collection Object table's view definition has the attribute isrequired="true".

    Screenshot 2024-08-07 at 3 21 26 PM
  2. Create a new Collection Object record

  3. Fill in required fields and save

  4. Go to the form meta and click "Show Carry Forward Button"

  5. Enable and click the gear next to "Show Bulk Carry Forward Count"

  6. Uncheck the "cataloger" field under "Relationships," then close all dialogs

  7. Set the "Bulk Carry Forward Count" to be greater than 1

  8. Carry forward and see that the new records cannot be modified and saved

Expected behavior Fields with the isrequired="true" attribute should be forcibly enabled.

Screenshots

https://github.com/user-attachments/assets/e2433de4-bcd3-48de-aae1-3d58c702c5a6

Specify 7 System Information - 2024-08-07T20_38_27.069Z.txt

Please, also fill out the following information manually:

CarolineDenis commented 2 months ago

@grantfitzsimmons, Do we want this? I thought it was only defined in schema config for the bulk carry