Recovery of branch selection doesn't work after a send operation

specklesystems / speckle-blender

https://speckle.systems/tag/blender/

Apache License 2.0

52 stars 9 forks source link

Recovery of branch selection doesn't work after a send operation #205

Closed JR-Morgan closed 3 months ago

JR-Morgan commented 4 months ago

As part of the send operation, the last step refreshes the UI so that the commit just sent displays in the UI

The branch recovery feature introduced by #196 doesn't work for this case...

Steps to reproduce:

Select a branch
Select objects & send
observe branch gets set to main after send

JR-Morgan commented 3 months ago

Blender bug report

A more detailed steps to reproduce:

From the list of Speckle projects, select a project that isn't the first project
Send an object to a said project
Observe, that the selection is in an invalid state, where no models appear in the drop down, and trying to receive leads to an unhandled exception

JR-Morgan commented 3 months ago

@overengineer are you interested in trying to find a fix, again, no worries if you're busy, but please let me know.

overengineer commented 3 months ago

Imma look into it

overengineer commented 3 months ago

Selected commit should change to the new commit after send operation, right?

JR-Morgan commented 3 months ago

ideally, yes

overengineer commented 3 months ago

That was a strange bug. Active stream is reset on send operation. I overrode it on selection restoration. Furthermore, there were two different cases. One is branch selection on default stream. Other is branch selection on a selected stream. This PR (#207) fixes both