Alessandro/web 2189 review core resolvers - Githubissues

specklesystems / speckle-server

The Speckle Server, Frontend, 3D Viewer, & other JS utilities.

https://speckle.systems

Other

678 stars 177 forks source link

Alessandro/web 2189 review core resolvers #3535

Closed alemagio closed 2 days ago

alemagio commented 3 days ago

Description & motivation

fixed resolvers
For commits resolvers the approach was to make it quick and dirty, it is not used in DUI2, the only field considered is the totalCount, so for now I made a patch to make it work even if it is unoptimized

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

[ ] My pull request follows the guidelines in the Contributing guide?
[ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
[ ] My commits are related to the pull request and do not amend unrelated code or documentation.
[ ] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

linear[bot] commented 3 days ago

WEB-2189 review core resolvers