speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 16 forks source link

Different SpeckleAbstract objects with the same properties all have the same hash. #100

Closed mishaelnuh closed 5 years ago

mishaelnuh commented 5 years ago

Step 0:

Actual Behaviour

Hash is only based on property dictionary. This causes issues when different objects with the same property dictionary are sent as it causes collisions.

Affected Projects

SpeckleCore

Reproduction Steps & System Config (win, osx, web, etc.)

  1. Create two classes with the same properties.
  2. Populate objects with same values.
  3. Allow SpeckleCore to serialize and send objects.

Proposed Solution (if any)

Add the assembly and type to the hashes of SpeckleAbstracts. Patch