SpeckleAbstract hash should be unique based on its property, type, and assembly.
Actual Behaviour
Hash is only based on property dictionary. This causes issues when different objects with the same property dictionary are sent as it causes collisions.
Affected Projects
SpeckleCore
Reproduction Steps & System Config (win, osx, web, etc.)
Create two classes with the same properties.
Populate objects with same values.
Allow SpeckleCore to serialize and send objects.
Proposed Solution (if any)
Add the assembly and type to the hashes of SpeckleAbstracts.
Patch
Step 0:
Expected Behaviour
SpeckleAbstract hash should be unique based on its property, type, and assembly.
Actual Behaviour
Hash is only based on property dictionary. This causes issues when different objects with the same property dictionary are sent as it causes collisions.
Affected Projects
SpeckleCore
Reproduction Steps & System Config (win, osx, web, etc.)
Proposed Solution (if any)
Add the assembly and type to the hashes of SpeckleAbstracts. Patch