search

speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 17 forks source link

Fix caching of deserialization. #116

Closed mishaelnuh closed 5 years ago

didimitrie commented 5 years ago

How was this borked before? I'll merge as it seems a rather innocuous change, but just to be able to be up to date...

mishaelnuh commented 5 years ago

Found the culprit here:

https://github.com/speckleworks/SpeckleCore/commit/461037906be7894ad4e138b98ee6549a604f9243#diff-f6132319669713cab7ba050c895a2dc0L46

Seems to be from a merge conflict caused by merging the master branch in.

It was borked before since it was trying to retrieving the ToNative type based on the original SpeckleObject type rather than the devolved one.