speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 17 forks source link

Adding ability to override timeout for object creating objects. #147

Closed nic-burgers-arup closed 4 years ago

nic-burgers-arup commented 4 years ago

I thought I might submit this even though it will probably trigger a wider discussion about timeouts. This change just relates to one call - the API call to create multiple objects on the server - as it is the only call at this point that is causing some issues in the connectors I'm working on.

Happy to for this to be rejected in favour of a wider change, and happy to help out with that if needed.

didimitrie commented 4 years ago

Thanks @nic-burgers-arup! This is a perfect hotfix... I know this problem has been raised before, and this should sort it out once clients implement it.

Uh, and on this note actually, @teocomi and I are now ramping up to a 2.0. It's not there yet, but that's where I would like to carry over the wider discussion on timeouts that you mention! In case you've missed, please do sign up for the speckle insider club here!