search

speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 17 forks source link

Moved a call to get types for a referenced assembly into the SafeLoad… #148

Closed nic-burgers-arup closed 4 years ago

nic-burgers-arup commented 4 years ago

…Assembly method.

I tried to remove a library from the Structural kit which no other plugin other than SpeckleGSA needs, which SpeckleGSA loads itself anyway - but found that because SpeckleRevit loads all assemblies and tries to get all types in all assemblies, a missing reference causes an uncaught exception to be thrown.

In a similar way to how SpeckleCore swallows exceptions related to the API/SDK libraries of specific applications not being present, I'd like it to ignore any issues with getting types from assemblies.

teocomi commented 4 years ago

Thanks @nic-burgers-arup , thanks god this annoying loading behaviour will improve in 2.0!