search

speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 17 forks source link

Reverted a line which caused ALL libraries from kits to be explicitly loaded #149

Open nic-burgers-arup opened 4 years ago

nic-burgers-arup commented 4 years ago

Hi guys

I see during kit initialisation that SpeckleCore used to load all kit assemblies using a ReflectionOnlyLoadFrom call but it was commented out in favour of a LoadFrom call at some point.

Could we revert it back to being a ReflectionOnlyLoadFrom call? That would solve this issue:

SpeckleGSA and the conversion library within the SpeckleStructural kit both reference the same file (SpeckleGSAInterfaces.dll) and I'm finding that it is often loaded twice into the loaded modules list, i.e. from 2 separate locations.

Note: this library doesn't need to be in the SpeckleStructural kit at all - in fact I'll remove it as soon as SpeckleRevit has been updated with the latest SpeckleCore version - but for the next short while SpeckleGSA will need to be able to cope with it.

I have a few workarounds in mind but I thought I might try to cause a change at the root of the issue -

Can you remember why it was changed in the first place?

Cheers

teocomi commented 4 years ago

Seems like it was changed by @didimitrie in December when he converted the library to .net standard, can you maybe test with .net standard to see if it works? I tried and it builds fine...