search

speckleworks / SpeckleCore

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems
MIT License
38 stars 16 forks source link

Handling exceptions for retrieving UserDictionaries #3

Closed PaulPoinet closed 7 years ago

PaulPoinet commented 7 years ago

Concerning the future SpeckleRhino interface, I noticed that there is no code written to handle ToNurbsCurve() conversions (in order to retrieve the UserDictionary), like it is done for the Grasshopper component here: https://github.com/speckleworks/SpeckleUserDataUtils/blob/dev/SetUserDataComponent.cs#L67-L74

Therefore I propose to add the same conversion here (I am not sure if this is consistent):

tonurbscurve
PaulPoinet commented 7 years ago

I tested that on my computer and works alright

didimitrie commented 7 years ago

Okay this seems to be an issue for https://github.com/speckleworks/SpeckleRhinoConverter.