search

speckleworks / SpeckleDynamo

Check a brand new Speckle at: https://github.com/specklesystems
https://speckle.systems/
MIT License
40 stars 6 forks source link

Speckle doesn't transfer NurbsCurves from Dynamo to Grasshopper #37

Closed vasshaug closed 6 years ago

vasshaug commented 6 years ago

Speckle doesn't transfer NurbsCurves from Dynamo to Grasshopper (GH). They appear as nulls in GH. Looks fine in the streams.

image image image

Dataset: Dataset.zip

Spec: Win 10 x64, Revit 2018.3, Dynamo 2.0.1, Rhino 6 SR7 with GH 1.0.0007, SpeckleDynamo 0.0.4 & SpeckleRhino build 420.

Thanks for any help.

didimitrie commented 6 years ago

Can replicate. Tested:

It fails in the RhinoConverter at deserialising the Domain prop of a nurbs curve, it seems that the DynamoConverter doesn't set this field. It's been introduced some time ago re problematic orientation of Arcs and other stuff.

Question for @alvpickmans and @teocomi: Either we make the domain prop of a SpeckleCurve optional, and I'll set a null check in the RhinoConverter, or we populate this from the DynamoConverter too. IMHO would be good to populate this from dynamo too, but not wise re the sdk. It is needed for rhino <> rhino interop.