Web socket disconnect - Githubissues

speckleworks / SpeckleRhino

Check a brand new Speckle at: https://github.com/specklesystems

https://speckle.works

MIT License

38 stars 16 forks source link

Web socket disconnect #226

Closed alexander-barwick closed 5 years ago

alexander-barwick commented 5 years ago

Expected Behaviour

Open gh script to find speckle nodes bring my data through

Actual Behaviour

Open gh script to find speckle nodes are red and wont bring my data through even after a forced refresh

didimitrie commented 5 years ago

@MrAlex8 , if i understand correctly the repoduction steps should be as follows:

create gh script with some senders/receivers
save it & close it
open it up again: receivers are in panic mode

Will look into it later on today!

didimitrie commented 5 years ago

The way we solved this currently is to recreate the old receivers next to the old ones, and re-wire the defintion to use the newly created ones, and then delete the old ones.

It's most probably a bug I introduced, but since it's not an issue going forward, it won't be fixed.

didimitrie commented 5 years ago

Okay, a bit more data on reproduction:

copy & pasting receivers will cause this error
copy & pasting senders will cause this error

Cut and paste seems to be fine. I've removed the wontfix label as it seems like a bug in the way gh clients handle serialisation/deserialisation; @fernandoruizz & @MrAlex8, if this happens again, please do let me know (we'll need a human actions stack trace going back 5 minutes as well).

didimitrie commented 5 years ago

i think this is now closed; didn't get any other reports of it (albeit apparently on some systems, when they go to sleep, things happen). We will re-open as needed