Closed AntoineDao closed 5 years ago
Please feel free to pull in anyone who is relevant to this conversation 😄
I haven't forgotten about this, it's just a pain recently to make time for this. We need to ping @mswaidan for sure, and any other server maintainers out there. will do on slack...
No rush and no worries. I'd talked about it in that issue and only just got around to pinging a proposed fix for it. If anyone's interested in getting a feel for what semantic release looks like in practice check out some of the ladybug tools repos. Honeybee, Ladybug, Dragonfly for example all use it (courtesy of yours truly!)
I'm on board
Cool, then i think we can go ahead. @AntoineDao, i've invited you to the the org team on appveyor. i've installed commitizen, and it seems fine. A question: would this be worth it?
commitizen
as a dev dependency (npm i --save-dev commitizen)git cz
. Or something on the lines of :)
I haven't set it up as a Dev dependency before but it seems worth it judging by this article
I'll do it just now after setting up appveyor.
Right, that's the appveyor.yml
file fixed. Please someone double check I didn't break anything in the process :see_no_evil: I have also added the required env vars to the appveyor config so if we merge this into master we should be good to go! (famous last words...)
let's find out what breaks :)
Somehow env vars aren't happening... BOOO! I'll set them up outside of the appveyor file and see what gives.
yeah, was just fiddling with that now, but need to run to work. Somehow it fails at the npm publish moment, which is actually not really needed (i was trying to see how we can skip that step)
Semantic-release now creates github releases and deploys new versioned docker containers.
This PR proposed we start using semantic release as discussed in #131 in order to automatically deploy versioned containers (it will also create github releases automatically based on commit messages).
If this is something we are happy to merge then the following must be done:
GH_TOKEN
andDOCKER_PASSWORD
(for @botsalot ) here. I don't have access to the appveyor settings so cannot do it unfortunatelysemantic-release
. Following this commit style is really easy if usingcomittizen
, which can be installed running the following command:Commits can then be made by typing the following command on your command line:
solves #131