Dimitrie/dev/hotfix usersearch

speckleworks / SpeckleServer

Check a brand new Speckle at: https://github.com/specklesystems

http://speckle.systems

MIT License

110 stars 29 forks source link

Dimitrie/dev/hotfix usersearch #155

Closed didimitrie closed 5 years ago

mswaidan commented 5 years ago

@didimitrie I think we'll want a way to ignore archived users for some (most?) searches.

E.g. I don't think you should be able to add archived users to your stream from the admin/streams/<streamId./sharing view.

I guess that filtering could happen client side?

didimitrie commented 5 years ago

yep, i know, that was a really knee-jerk fix ( 😬) as it borked things in production in arup. filtering could happen clientside, that would be easy! but it should also happen server side; that whole logic in UserSearch.js needs to be revamped and thought through a bit more...