fix(models/DataStream.js): setting private property of streams

speckleworks / SpeckleServer

Check a brand new Speckle at: https://github.com/specklesystems

http://speckle.systems

MIT License

110 stars 29 forks source link

fix(models/DataStream.js): setting private property of streams #205

Closed jenessaman closed 4 years ago

jenessaman commented 4 years ago

This PR fixes setting the default value for streams to private if the environment variable says so. Issue was that ENV_VAR_X=true get read into node as "true".

didimitrie commented 4 years ago

Hey @jenessaman! Nice to see you in Speckle Land (hm... you returned, against @mishaelnuh's solid advice to the contrary)! Totally valid PR, easy to check, passes tests, so it gets merged :)

As I recently caused borkage because I didn't respect the contribution guidelines I wrote, I feel obliged to inform you that, for the next PR, we'll be looking for:

an issue flagging the problem
the above issue referenced in the PR (alternatively, PR can describe the issue a wee bit).

Anyway, totally stoked, and keep an eye out for 2.0!

botsalot commented 4 years ago

:tada: This PR is included in version 1.9.11 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

jenessaman commented 4 years ago

Woohoo! Thanks Dimitrie! Noted re PR requirements - will make sure to include reference to an issue or description of the issue in the future.

And yes, totally excited to have finally entered Speckle Land, hopefully @mishaelnuh won't have to tell me "i told you so" 😜