Closed najwanan closed 1 year ago
Thanks Daniel!
Did some reading up on best practices for classNames, and sr-only class. Most of it was pretty straightforward, just wasn't sure if I interpreted the issue with h1 and sr-only correctly. I'll touch base in the morning, other than that this should be good to go!
@dashcraft This one has been update with the h1 tags and sr-only. Should be good to merge now? 🤞🏽
Thanks, pulled it down and tested it. Looks good.
Ticket Description <-- Copy and paste or write the tickets description here--> UI styling for download page
Description of Changes <-- Brief description of the changes you made, files you touched, etc -->
Before and After for UI Updates <-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->
Before:
After:
For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?