specollective / insights-agent-web-app

Web client for the Insights Agent application.
2 stars 1 forks source link

45/Web App: Household Size Submit Bug #65

Closed Saige243 closed 1 year ago

Saige243 commented 1 year ago

Ticket Description Fixes #45

Description of Changes

Question actually is required via Yup, so changed the frontend to reflect, then changed initial placeholder value dropdown to 0 (a. to match iPad household question, and as a second layer to the user to show the question's requirement, as you can't have a household of 0.)

Upon changing the household value the form submits successfully.

Before and After for UI Updates

Before:

Screenshot 2022-12-07 at 2 46 17 PM

After:

Screenshot 2022-12-07 at 2 45 22 PM

For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?

Saige243 commented 1 year ago

Couldn't figure out what the error was until I realized the tests were asking for the household question without the on the end as it wasn't labeled as required before. But it should be required, so I changed the frontend and the tests to reflect. Now all the tests pass. If this isn't the right option I can revert.