search

specollective / insights-agent-web-app

Web client for the Insights Agent application.
2 stars 1 forks source link

Issue 43: Survey Form Validation Errors #67

Closed YolineB closed 1 year ago

YolineB commented 1 year ago

Ticket Description

Fixes #43 User should be visually notified for missing/incorrect fields. Figma

Description of Changes

Update validation schemas and fixed test for survey page Added border line and error message Rest form and cleared values to default when clicking clear form

Before and After for UI Updates

Before:

Desktop

image

Mobile

image

After:

Desktop:

image

Mobile:

image

For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?

YolineB commented 1 year ago

Note additional computer competence questions were added that need refactoring. Errors for that section are blocked until #75 is complete.