[x] Race checkbox needs second race option (see constants > survey.js )
[ ] Zero is currently being accepted as an answer for the house members dropdown question, should be 1 or more **
**Thinking 0 might be more beneficial than 1: if it defaults to 1, and the user doesn't change it (i.e. they have one person in their household so they leave it), it will read as untouched and throw an error. If they actually do have 1 person in the household, they'll have to click another number and then 1, since 1 as the default value won't initially read as 1 (this was happening before it was changed to 0.) My thinking with 0 is it shows that the question has been untouched (you can't have a household with 0 people) and that it needs to be changed to a positive number, even if you live alone (i.e. 1). (I can also change to 'Select One' or something like that if we don't like 0.) (Photo below.)
Description of Changes
Added second portion of races back & ensured responsiveness.
Before:
After:
For PR Reviewer
Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
Does this file match the related tickets linked figma file, or does it pass the visual smell test?
If this file contains javascript, does the javascript pass the smell test?
If you don't feel super confident in your review, did you assign someone more senior to double check?
Fixes #70 Ticket Description Figma
**Thinking 0 might be more beneficial than 1: if it defaults to 1, and the user doesn't change it (i.e. they have one person in their household so they leave it), it will read as untouched and throw an error. If they actually do have 1 person in the household, they'll have to click another number and then 1, since 1 as the default value won't initially read as 1 (this was happening before it was changed to 0.) My thinking with 0 is it shows that the question has been untouched (you can't have a household with 0 people) and that it needs to be changed to a positive number, even if you live alone (i.e. 1). (I can also change to 'Select One' or something like that if we don't like 0.) (Photo below.)
Description of Changes Added second portion of races back & ensured responsiveness.
Before:
After:
For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?