specollective / insights-agent-web-app

Web client for the Insights Agent application.
2 stars 1 forks source link

Web App: Replace Hardcode with Translations #79

Closed Saige243 closed 1 year ago

Saige243 commented 1 year ago

Ticket Description Fixes #34

Description of Changes I replaced all hardcoded copy with translations and refactored for consistency.

Before and After for UI Updates (No photos - everything looks the same) Before: N/A After: N/A

For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?