specollective / insights-agent-web-app

Web client for the Insights Agent application.
2 stars 1 forks source link

34/erplace hardcoded copy with translations #91

Closed dashcraft closed 1 year ago

dashcraft commented 1 year ago

Ticket Description <-- Copy and paste or write the tickets description here-->

Description of Changes <-- Brief description of the changes you made, files you touched, etc -->

Before and After for UI Updates <-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:

After:

For PR Reviewer Does this file change the yarn.lock, package.json or package-lock.json file? If so, why? If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views? Does this file match the related tickets linked figma file, or does it pass the visual smell test? If this file contains javascript, does the javascript pass the smell test? If you don't feel super confident in your review, did you assign someone more senior to double check?