Describe the changes you've made to resolve the issue
Modifies the GetInvolved, ContactForm, and DonationTable components to address the following issues (taken verbatim from linked issue above)
Use the contribution tiers as the primary image
Remove learn more show more info interaction
Link to documentation site (we can choose the specific page later)
Body copy font is incorrect, should be Montserrat
Donate button should open OC in a new window
Contact Us button doesn't anchor to the Contact form at the bottom of the page
Add screenshots of the UI before and after your changes have been made
Before and After - cards
Before and After - contribution table
1)
2)
After:
Before and After - mobile (IPhone XR)
Additional Notes
On the contribution table in GetInvolved.tsx, I will work to right align the ellipsis (...) on the next PR per Figma design.
For mobile, I chose to keep the existing DonationImg image since that adding a contribution tier would have likely necessitated another card. If another card with the contribution tier is desired, perhaps that could be a future PR.
Code Review Checklist
[ ] Have the package.json or package-lock.json been changed? If so, does the pull request description say why?
[ ] Has the UI for mobile and desktop been changed, did you test on IphoneXr and desktop views?
[ ] Does the UI match the requirements in the ticket and designs in figma; does it pass the visual smell test?
[ ] Have TypeScript files been changed, does the TypeScript pass the smell test?
[ ] If you don't feel super confident in your review, did you assign someone more senior to double check?
Pull Request Process
Describe the issue you are trying to resolve
This PR addresses six of 12 tasks in Issue 86 - (https://github.com/specollective/spec-frontend/issues/86) - am trying to merge in key changes as they are made.
Describe the changes you've made to resolve the issue
GetInvolved
,ContactForm
, andDonationTable
components to address the following issues (taken verbatim from linked issue above)Add screenshots of the UI before and after your changes have been made
Before and After - cards
Before and After - contribution table
1) 2)
After:
Before and After - mobile (IPhone XR)
Additional Notes
GetInvolved.tsx
, I will work to right align the ellipsis (...
) on the next PR per Figma design.DonationImg
image since that adding a contribution tier would have likely necessitated another card. If another card with the contribution tier is desired, perhaps that could be a future PR.Code Review Checklist