issues
search
specollective
/
spec-frontend
Frontend for SPEC's informational website.
3
stars
0
forks
source link
129 fix hero content on mobile
#130
Closed
najwanan
closed
1 year ago
najwanan
commented
1 year ago
Pull Request Process
Describe the issue you are trying to resolve
[ ] Fixing dimensions of hero section on mobile per figma design
[x] Unhide Our Services section
Describe the changes you've made to resolve the issue
Made edits to styling in Hero component.
Add screenshots of the UI before and after your changes have been made
Mobile
Before
After
Desktop
Before
After
Code Review Checklist
[ ] Have the package.json or package-lock.json been changed? If so, does the pull request description say why?
[ ] Has the UI for mobile and desktop been changed, did you test on IphoneXr and desktop views?
[ ] Does the UI match the requirements in the ticket and designs in figma; does it pass the visual smell test?
[ ] Have TypeScript files been changed, does the TypeScript pass the smell test?
[ ] If you don't feel super confident in your review, did you assign someone more senior to double check?
Pull Request Process
Describe the issue you are trying to resolve
Describe the changes you've made to resolve the issue
Made edits to styling in Hero component.
Add screenshots of the UI before and after your changes have been made
Mobile
Before
After
Desktop
Before
After
Code Review Checklist