Upgrade for Xcode 10.1 (and Fix Warnings)

specta / expecta

A Matcher Framework for Objective-C/Cocoa

MIT License

1.59k stars 158 forks source link

Closed nsforge closed 5 years ago

nsforge commented 5 years ago

This PR:

Upgrades the project for Xcode 10.1
Adds all of the suggested compiler warnings suggested when when upgrading the project
Fixes all outstanding compiler warnings
Updates the iOS deployment target from 5.1.1 to 8.0 (since Xcode 10 only supports iOS 8.0+)

nsforge commented 5 years ago

I'm having a quick look into the CI scripts now…

nsforge commented 5 years ago

nsforge commented 5 years ago

@tonyarnold once https://github.com/specta/expecta/pull/196 has been merged into master, I can merge master back into this PR so that we can get CI going again.

nsforge commented 5 years ago

@tonyarnold The CI fixes have been merged in, so this is ready for review again.

tonyarnold commented 5 years ago

Thanks for the contribution, @nsforge! Much appreciated!