spectralDNS / shenfun

High performance computational platform in Python for the spectral Galerkin method
http://shenfun.readthedocs.org
BSD 2-Clause "Simplified" License
197 stars 42 forks source link

Undefined order of symbols when using `Function(buffer)` parameter #105

Open CharlesJQuarra opened 1 week ago

CharlesJQuarra commented 1 week ago

Looking at this line in the documentation of Function I'm wondering about how the sympy expression free_symbols is used to map each product space to coordinates.

Looking at the code, I don't think is clear what is going on here, or how it is being handled when there are more than one free symbol in the passed expression.

Ideally there should be an argument that maps each free symbol to a specific factor in the tensor product space.

thoughts?

mikaem commented 1 week ago

Hi Sorry about the poor documentation here. The sympy symbols x, y, z, r, s are used for the spaces in axes 0, 1, 2, 3, 4 of any tensorproductspace. You can search the code for 'xyzrs' to find where this is currently being used.