search

spectralpython / spectral

Python module for hyperspectral image processing
MIT License
574 stars 139 forks source link

as per request #160

Closed YannChemin closed 1 month ago

YannChemin commented 11 months ago

Loads Relab library basic info, does not load type, class and subclass some code using ignorefiles is not needed

LaurentBerder commented 3 months ago

@tboggs, I have extensively tested it, and it works very well. Can we merge it in the master?

YannChemin commented 2 months ago

Hi @tboggs, any update on this side?

tboggs commented 2 months ago

Hi @YannChemin, apologies for the delay. I'm away from my dev system for a few days. I'll review & test this by next week.

tboggs commented 2 months ago

The code looks good to me but before merging to master, please add some basic unit tests for creating and querying a Relab database. You should be able to copy most of the test code from one of the other databases in this file (you can also add the unit tests to the same file).

YannChemin commented 2 months ago

This is done, test added

YannChemin commented 2 months ago

@tboggs

tboggs commented 1 month ago

@YannChemin Thanks for adding the unit tests. I will have time to test the code in the next day or two and merge into master.

In the meantime, could you please rename the relabDatabase class to RelabDatabase to maintain pep8 compliance for class names?

YannChemin commented 1 month ago

OK done @tboggs

tboggs commented 1 month ago

@YannChemin, I'm ready to look at this now. Are PR #158 and #160 identical, just merging to different branches?