search

spectralpython / spectral

Python module for hyperspectral image processing
MIT License
573 stars 139 forks source link

Issue 56 #57

Closed lewismc closed 7 years ago

lewismc commented 7 years ago

Hi @tboggs this PR addresses the issue I've described at #56 I have no idea why the PR is including earlier work done by you. I can confirm this works as follows

print(view)

ImageView object:
  Display bands       :  (29, 19, 9)
  Interpolation       :  <default>
  RGB data limits     :
    R: [-0.004999999888241291, 0.56691563129425049]
    G: [-0.017857706174254417, 0.53872084617614746]
    B: [-0.084467947483062744, 0.3872545063495636]
tboggs commented 7 years ago

It looks like the other commits are included with your pull request because you based your changes off of the master branch but want to merge with python3, which is several commits behind master. Your change looks fine to me. I just brought python3 in sync with master so I'll merge your PR and see what happens.

tboggs commented 7 years ago

I sync'd the branches but all the other commits still show in your PR. I'm not a git wizard so I don't know if that will dork things up or not. Could you do a rebase of your ISSUE-56 branch to eliminate the previous commits from the diffs? That should be straightforward since python3 and master are now even. Also, did you intend for the changes to .gitignore to be included?

lewismc commented 7 years ago

Thanks @tboggs I've just created a new PR over on https://github.com/spectralpython/spectral/pull/58.