search

spectreconsole / spectre.console

A .NET library that makes it easier to create beautiful console applications.
https://spectreconsole.net
MIT License
9.45k stars 499 forks source link

Would it be possible to condition the build-only PackageReferences? #1421

Closed baronfel closed 10 months ago

baronfel commented 10 months ago

Hi! I am trying to get Spectre.Console added to the dotnet/source-build-externals repo so that the SDK and MSBuild can take references to it in ways that work with our Linux Source Build partners' support lifecycles. As a part of that, I have a patch that comments out a number of build-metadata-related packages, but patches like this are fragile. Would you all be amenable to a solution where a property is checked in a Condition on this ItemGroup, and then the source-build-externals build of Spectre.Console could pass that property? If so, I'd be happy to contribute that.

patriksvensson commented 10 months ago

@baronfel Sure, sounds reasonble to me. We will happily accept a patch for this 🙂