Remove [DebuggerDisplay] from Paragraph

spectreconsole / spectre.console

A .NET library that makes it easier to create beautiful console applications.

https://spectreconsole.net

MIT License

8.92k stars 454 forks source link

Remove [DebuggerDisplay] from Paragraph #1477

Closed martincostello closed 4 months ago

martincostello commented 4 months ago

Fixes #1476

[x] I have read the Contribution Guidelines
[x] I have commented on the issue above and discussed the intended changes
[ ] A maintainer has signed off on the changes and the issue was assigned to me
[ ] All newly added code is adequately covered by tests
[x] All existing tests are still running without errors
[x] No documentation changes are required.

Changes

Remove broken [DebuggerDisplay] attribute.

patriksvensson commented 4 months ago

I appreciate where you’re coming from, but wouldn't it be better to fix the problem?

martincostello commented 4 months ago

I considered that briefly, but that looked like a much more involved change to add a custom debugger proxy to start walking through the internal state, and not being familiar with the internals I didn't see anything obvious to use in its place as a trivial replacement.

patriksvensson commented 4 months ago

Merged! Thank you for your contribution. Much appreciated! 👍