Closed Kissaki closed 3 months ago
I see some chore:
commit prefixes but none other. The contribution guidelines do not mention any. So I omitted using a commit prefix.
I edited it directly in GitHub UI. Is the addition of the end-of-file newline an issue?
best-practices refers and links to the
Markup.Escape
method but labeled itEscapeMarkup
.I got quite confused trying to find EscapeMarkup. Using the typical class dot method pattern seems preferable. It also matches what you write in code.
Despite the caps NOT I hope it's okay to create this PR as-is, for this trivial obvious change instead of first creating a Discussion and then a ticket and the the PR.
Checklist
[ ] I have commented on the issue above and discussed the intended changes[ ] A maintainer has signed off on the changes and the issue was assigned to me[ ] All newly added code is adequately covered by tests[ ] The documentation was modified to reflect the changes OR no documentation changes are required.