spectreconsole / spectre.console

A .NET library that makes it easier to create beautiful console applications.
https://spectreconsole.net
MIT License
9.28k stars 479 forks source link

Make method reference to Markup.Escape more obvious #1574

Closed Kissaki closed 3 months ago

Kissaki commented 3 months ago

best-practices refers and links to the Markup.Escape method but labeled it EscapeMarkup.

I got quite confused trying to find EscapeMarkup. Using the typical class dot method pattern seems preferable. It also matches what you write in code.

Despite the caps NOT I hope it's okay to create this PR as-is, for this trivial obvious change instead of first creating a Discussion and then a ticket and the the PR.

Checklist

Kissaki commented 3 months ago

I see some chore: commit prefixes but none other. The contribution guidelines do not mention any. So I omitted using a commit prefix.

Kissaki commented 3 months ago

I edited it directly in GitHub UI. Is the addition of the end-of-file newline an issue?