Offer to search Google when no search results are returned

spectresystems / jarvis

Your robotic butler.

MIT License

646 stars 53 forks source link

Offer to search Google when no search results are returned #62

Open jonstodle opened 6 years ago

jonstodle commented 6 years ago

Adds a function on IQueryProvider to supply a "fallback result" which supplies a generic search with the provider. This makes it possible to add a setting specifying a desired fallback provider in the user settings later.

This closes #8.

jonstodle commented 6 years ago

I see your point about not every provider being a global provider. Do you think the IsGlobalProvider should be on IQueryProvider or some other interface?

reinismu commented 6 years ago

Maybe not a property, but extended IQueryProvider -> IGlobalQueryProvider. Tho it depends. Need more people opinion on this.

jonstodle commented 6 years ago

Yeah, that's more like what I was leaning towards too.

Let's get some more opinions, though 👍

patriksvensson commented 6 years ago

Nice initiative, but I think this PR strays from the original issue which was that the Google provider should allow you to search for things not suggested by the Google web service.

Personally I think that each provider should be responsible for whether or not to show fallback values, and not done globally.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}