speculatrix / tvh_epg

A very simple web based EPG for TVHeadend
GNU General Public License v3.0
27 stars 1 forks source link

TV logos now too large #13

Closed dgilbert2 closed 3 years ago

dgilbert2 commented 3 years ago

Following what I believe is a recent change to the mainstream browsers (on Windows), i.e. Chrome, Firefox, Microsoft Edge, TVLogos are now massive, see below.

My tvh_epg has not changed and I've tried browsers on another PC and the result is the same. However, it still displays correctly on my iPhone / iPad.

image

dgilbert2 commented 3 years ago

I've done some digging into this and it appears from what I can see, that Windows browsers are now ignoring the img height% command. So, by adding specific height and width it reduces the size as it should do, which I've tested on Windows Chrome, Firefox and Edge as well as iOS Safari. The two lines I've changed in tvh_epg to get my system working as it should, are detailed below. Hope this helps.

Line 517
WAS '<img height="12%%" src="%s" /></td>' %
NOW '<img height="80" width="140" src="%s" /></td>' %

Line 719
WAS '<img height="12%%" src="%s" /></td>' %
NOW '<img height="80" width="140" src="%s" /></td>' %

Screen now looks like;

image

speculatrix commented 3 years ago

Hi, sorry for delay in fixing this, I just pushed a commit. pull down the latest version and if you go into settings you can now set a size, about 64 h x 80 w seems ok

speculatrix commented 3 years ago

let me know what you think if this solves the problem.

dgilbert2 commented 3 years ago

Thanks, this resolves the logo size problem and I like being able to set own w & h values.

I still have a problem though with lines 566 & 569, browser.close(), ie I need to # these out otherwise I get errors;

AttributeError: 'ServiceBrowser' object has no attribute 'close' args = ("'ServiceBrowser' object has no attribute 'close'",) with_traceback =

BTW, no issues with fix #12 , as long as I set to "plain".