search

spedas / pyspedas

Python-based Space Physics Environment Data Analysis Software
https://pyspedas.readthedocs.io/
MIT License
155 stars 60 forks source link

pyspedas/pyspedas/mms/feeps/mms_feeps_remove_bad_data.py line 50 #225

Closed PluckZK closed 2 years ago

PluckZK commented 2 years ago

Are October 2017 and October 2018 the starting time for bad eyes tables? If so, then you should not take the closest table, but take the table according to the time period.

ericthewizard commented 2 years ago

Thanks for the report!

This is probably a better question for the MMS FEEPS team. I did confirm with Joe Fennell, just a few weeks ago, that the current way this works should be fine.

ericthewizard commented 2 years ago

Update: turns out, this is a different spot than the one I confirmed with Joe Fennell a few weeks ago (though very similar question/issue).

I checked the IDL code (the team's official routine) and it works the same way.

I suspect the current algorithm works the way the team intends for it to work, but you could always check with them to be sure.

PluckZK commented 2 years ago

Update: turns out, this is a different spot than the one I confirmed with Joe Fennell a few weeks ago (though very similar question/issue).

I checked the IDL code (the team's official routine) and it works the same way.

I suspect the current algorithm works the way the team intends for it to work, but you could always check with them to be sure.

Thank you vrey much !