search

spedas / pyspedas

Python-based Space Physics Environment Data Analysis Software
https://pyspedas.readthedocs.io/
MIT License
147 stars 58 forks source link

pyspedas missions MAVEN, THEMIS define global parameters #750

Closed nickssl closed 6 months ago

nickssl commented 6 months ago

MAVEN defines global parameters for username and password. This could affect other projects.

THEMIS also defines some global parameters in gmag.py

In general, we should avoid global parameters.

nickssl commented 6 months ago

I found this issue in the process of fixing the MAVEN docstrings. I will try to fix the global parameters issue while working with the docstrings and documentation for MAVEN. That's why I assigned this task to myself (if there is no objection).

nickssl commented 6 months ago

Fixed maven by including username and password parameters in the CONFIG dictionary.

Fixed themis/ground/gmag.py by introducing an object Themis_gmag that holds the required information for the gmag stations.