speechbrain / benchmarks

This repository contains the SpeechBrain Benchmarks
Apache License 2.0
83 stars 35 forks source link

HiFi-GAN #38

Closed Chaanks closed 1 month ago

poonehmousavi commented 2 months ago

@Chaanks it seems that some of the checks are not passed.

poonehmousavi commented 2 months ago

Thanks @Chaanks for this PR. Everything works smoothly. I have some comments regarding formatting:

  1. All recipes should follow the same structure: dataset/task/architecture/. Please follow the same format as in the discriminative tasks in the DASB branch, here.
  2. We should have the same script as discriminative rask for generative tasks. Please make sure, everything is consistent and compatible with the instructions in readme fil. For example the name of the py ad YAML.
  3. The kmeans repository is transferred to speechbrain/SSL_Quantization, please update it in your recipe.
  4. I also put some comments in the code.