Updated [voice] tag support and extensive refactoring to improve code reuse

speechmarkdown / speechmarkdown-js

Speech Markdown grammar, parser, and formatters for use with JavaScript.

MIT License

76 stars 16 forks source link

Updated [voice] tag support and extensive refactoring to improve code reuse #68

Closed afirstenberg closed 2 years ago

afirstenberg commented 2 years ago

This is built on top of the previous pull request for [ipa] and [lang]. It includes [voice] support for the Google Assistant, along with refactoring how [voice] is supported for Alexa as well, allowing for voice name aliasing through a new attribute of the Options object. It also refactors how the generators run to try and reduce some of the repetitive code. Tests have been run and verified, and new tests have been added.

rmtuckerphx commented 2 years ago

I really like what you did here.

afirstenberg commented 2 years ago

Replaced by PR 70