speechmatics / speechmatics-js-sdk

Javascript and Typescript SDK for Speechmatics
MIT License
39 stars 6 forks source link

make it possible to use in chrome extension background script #15

Closed IsaacHook closed 11 months ago

IsaacHook commented 1 year ago
TudorCRL commented 12 months ago

@IsaacHook thanks for the contribution! We're going to put together a quick browser extension example so that we can test these code changes and once that's done we'll get them merged in

IsaacHook commented 12 months ago

nice thanks! only got it working for chrome, but should be easy to extend for firefox etc as well

TudorCRL commented 11 months ago

@IsaacHook I've tested this PR now and it all seems to be working as you say - thanks for the contribution! There's just one thing needed before the merge, which is formatting it to fit the standards of the rest of the repo. I suspect you might have a formatter such as prettier configured in your IDE which seems to differ slightly from the one we use and has caused other changes in the diff. If you run npm run format from inside your local copy of the repo and commit those formatting changes, it should match the styling of the rest of the repo and remove the non-functional code changes in this PR so that we can merge

IsaacHook commented 11 months ago

Ok should have removed those file changes now.

Those changes came from the formatter for me. tried with both npm & pnpm both seemed to ignore the biome config. disabled all extensions, tried reinstalling & using a separate terminal. must be something with my local setup if no one else is experiencing this. will look into it further when I have more time.

nickgerig commented 11 months ago

Thanks @IsaacHook - LGTM. We'll see if we can improve the Biome integration, we had similar issues on an internal repo so could well be something on our side.