Closed TudorCRL closed 9 months ago
Can I add prettier config to this repo?
It seems npx run check
from the root is not checking these files (which is what runs on CI).
Please could you format the files added/changed in this PR with rome? It would make it a lot easier for me to pick out my changes and make a PR.
Perhaps use the vscode addon if you aren't already (assuming you use vscode).
I think it would be worthwhile committing this to the repo, as this would have prevented my prettier formatter from kicking in my default:
.vscode/settings.json
{
"[javascript]": {
"editor.defaultFormatter": "rome.rome"
},
"[typescript]": {
"editor.defaultFormatter": "rome.rome"
},
"[typescriptreact]": {
"editor.defaultFormatter": "rome.rome"
}
}
It seems
npx run check
from the root is not checking these files (which is what runs on CI).Please could you format the files added/changed in this PR with rome? It would make it a lot easier for me to pick out my changes and make a PR.
Perhaps use the vscode addon if you aren't already (assuming you use vscode).
I think it would be worthwhile committing this to the repo, as this would have prevented my prettier formatter from kicking in my default:
.vscode/settings.json
{ "[javascript]": { "editor.defaultFormatter": "rome.rome" }, "[typescript]": { "editor.defaultFormatter": "rome.rome" }, "[typescriptreact]": { "editor.defaultFormatter": "rome.rome" } }
I've run the formatter and added the .vscode changes now, so hopefully all the formatting issues should be resolved
I had some thoughts around moving some code that could be reusable across demos in to their own hooks, but this is a tweak to code structure and doesn't need to hold up the example going in or the publishing of the blog post.
Also, I was thinking as this may serve as the best starting point for a node/nextjs project, it may be good to implement sessions with jwt token refresh in at some point (rather than getting a jwt token on every page load), but again not something we need now and perhaps it would only serve to complicate the example.
@Box333 can you start a discussion here: https://github.com/orgs/speechmatics/discussions instead? Or an issue in the JS SDK issues section here: https://github.com/speechmatics/speechmatics-js-sdk/issues
Hi nickgerig, i have removed my comment here and opened an issue as a feature request. https://github.com/speechmatics/speechmatics-js-sdk/issues/48 thank you
Add microphone input demo. Includes a nextjs app showcasing how to use microphone inputs to send data to the Speechmatics WebSocket.