speechmatics / speechmatics-python

Python library and CLI for Speechmatics
https://speechmatics.github.io/speechmatics-python/
MIT License
58 stars 14 forks source link

Add operating-point setting #36

Closed benjamingorman closed 3 years ago

benjamingorman commented 3 years ago

Adds operating-point to the CLI as well as to TranscriptionConfig as a property.

I've tested against the latest published transcriber: by default the setting will not be used and transcription will be fine. If you do use the option though you'll get an error about the option not being in the spec - but this is expected since we haven't published transcribers with the new spec yet.

viren-nadkarni commented 3 years ago

@benjamingorman @jrg1381 Just realised that there's a risk this may break existing integrations if TranscriptionConfig is instantiated with positional parameters

TranscriptionConfig('en', 'en-GB')  # Previously =>(language, output_locale...)
=> TranscriptionConfig(language='en', operating_point='en-GB', output_locale=None, additional_vocab=None, diarization=None, max_delay=None, speaker_change_sensitivity=None, enable_partials=None, punctuation_overrides=None, n_best_limit=None)

I think it makes sense to make operating_point the last argument.